deshanxiao commented on PR #1889: URL: https://github.com/apache/orc/pull/1889#issuecomment-2069529985
Hi @wgtmac I checked vcpkg and the previous patch can not apply any more: ``` -- Downloading https://github.com/wgtmac/orc/archive/ORC-1689.tar.gz -> wgtmac-orc-ORC-1689.tar.gz... -- Extracting source /home/deshanxiao/vcpkg/downloads/wgtmac-orc-ORC-1689.tar.gz -- Applying patch fix-cmake.patch CMake Error at scripts/cmake/z_vcpkg_apply_patches.cmake:34 (message): Applying patch failed: Checking patch c++/src/CMakeLists.txt.. ``` This will not break our existing version . Feel free to merge the PR. And I will make a PR to remove the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
