wgtmac commented on PR #1889:
URL: https://github.com/apache/orc/pull/1889#issuecomment-2071248675

   Thanks for the check and feedback! @h-vetinari 
   
   For the 2nd patch, unfortunately it requires some additional change (not 
just removing `STATIC` keyword). The only patch on the Conan side since Apache 
ORC 2.0.0 is doing the similar thing: 
https://github.com/conan-io/conan-center-index/blob/master/recipes/orc/all/conanfile.py#L135-L137.
 I will try to support building shared libraries natively but for now let's 
still patch this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to