ffacs commented on code in PR #1932:
URL: https://github.com/apache/orc/pull/1932#discussion_r1599815997


##########
c++/src/ByteRLE.cc:
##########
@@ -186,16 +186,15 @@ namespace orc {
 
   void ByteRleEncoderImpl::recordPosition(PositionRecorder* recorder) const {
     uint64_t flushedSize = outputStream->getSize();
-    uint64_t unflushedSize = static_cast<uint64_t>(bufferPosition);
+    uint64_t unusedBufferSize = static_cast<uint64_t>(bufferLength - 
bufferPosition);

Review Comment:
   Why use `unusedBufferSize` not `unflushedSize`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to