luffy-zh commented on PR #1932: URL: https://github.com/apache/orc/pull/1932#issuecomment-2109991836
> @luffy-zh Thank you for making the PR. Could you explain why we need `outputStream->getRawInputBufferSize()` to record position? it seems that `flushedSize` and `bufferPosition` were't changed. When we call recordPosition(), we need to record the output buffer length and input buffer length. We have multiple blocks in the input buffer, 'bufferPosition' only records the effective length of the last block, that's why we need to use getRawInputBufferSize() in the outputStream. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
