luffy-zh commented on code in PR #1932:
URL: https://github.com/apache/orc/pull/1932#discussion_r1604654617
##########
c++/src/Compression.cc:
##########
@@ -200,14 +210,16 @@ namespace orc {
}
CompressionStream::CompressionStream(OutputStream* outStream, int
compressionLevel,
- uint64_t capacity, uint64_t blockSize,
MemoryPool& pool,
+ uint64_t capacity, uint64_t
compressionBlockSize,
+ uint64_t memoryBlockSize, MemoryPool&
pool,
WriterMetrics* metrics)
- : CompressionStreamBase(outStream, compressionLevel, capacity,
blockSize, pool, metrics),
- rawInputBuffer(pool, blockSize) {
+ : CompressionStreamBase(outStream, compressionLevel, capacity,
compressionBlockSize,
+ memoryBlockSize, pool, metrics),
+ rawInputBuffer(pool, memoryBlockSize) {
// PASS
}
- bool CompressionStream::Next(void** data, int* size) {
+ void CompressionStream::compressWithRawFallback() {
Review Comment:
I'll rename it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
