luffy-zh commented on code in PR #1932:
URL: https://github.com/apache/orc/pull/1932#discussion_r1606538220
##########
c++/src/Compression.cc:
##########
@@ -1203,8 +1237,8 @@ namespace orc {
case CompressionKind_ZLIB: {
int level =
(strategy == CompressionStrategy_SPEED) ? Z_BEST_SPEED + 1 :
Z_DEFAULT_COMPRESSION;
- return std::make_unique<ZlibCompressionStream>(outStream, level,
bufferCapacity,
- compressionBlockSize,
pool, metrics);
+ return std::make_unique<ZlibCompressionStream>(
+ outStream, level, bufferCapacity, compressionBlockSize,
memoryBlockSize, pool, metrics);
Review Comment:
Good advice. I will do this in my next work if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
