ffacs commented on code in PR #2010:
URL: https://github.com/apache/orc/pull/2010#discussion_r1726598323
##########
c++/src/ColumnWriter.cc:
##########
@@ -922,8 +931,8 @@ namespace orc {
}
};
- std::map<DictEntry, size_t, LessThan> dict_;
- std::vector<std::vector<char>> data_;
+ mutable std::vector<DictEntryWithIndex> flat_dict;
Review Comment:
Please follow the naming style.
[The format check didn't fail as
expected.](https://github.com/apache/orc/actions/runs/10503087327/job/29095780106?pr=2010#step:4:66)
##########
c++/src/ColumnWriter.cc:
##########
@@ -1103,6 +1115,12 @@ namespace orc {
throw InvalidArgument("Failed to cast to StringVectorBatch");
}
+ EncodedStringVectorBatch* encoded_string_batch =
+ dynamic_cast<EncodedStringVectorBatch*>(&rowBatch);
+ if (encoded_string_batch) {
Review Comment:
Maybe let the caller call calculateDataAndLength() is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
