taiyang-li commented on code in PR #2010:
URL: https://github.com/apache/orc/pull/2010#discussion_r1726685375
##########
c++/src/ColumnWriter.cc:
##########
@@ -1103,6 +1115,12 @@ namespace orc {
throw InvalidArgument("Failed to cast to StringVectorBatch");
}
+ EncodedStringVectorBatch* encoded_string_batch =
+ dynamic_cast<EncodedStringVectorBatch*>(&rowBatch);
+ if (encoded_string_batch) {
Review Comment:
I'm afrait it will increase user's mental burden. Do you think make it
transparent for user is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
