sodonnel commented on pull request #1549: URL: https://github.com/apache/ozone/pull/1549#issuecomment-721588739
This change is proving slightly tricky in the tests. I have fixed the unit test problems, but the integration tests are more difficult to fix. In the problems I have looked at, the issue is driven by ContainerCache being a singleton / static. This means the same cache is shared by all DNs in a mini-cluster and when a DN is restarted in the mini-cluster, the RocksDB instances are still open in the cache. When the DN is starting up, it fails to open them "uncached" as they are already open in the cache. The solution is either: 1. Make ContainerCache not be static and create a new instance somewhere in the DN which is reused. 2. On DN shutdown / startup, the cache should be purged, but as the cache is shared by all DNs in the JVM, that impacts the other running DNs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
