elek commented on pull request #1549: URL: https://github.com/apache/ozone/pull/1549#issuecomment-730312660
Thanks the detailed explanation @sodonnel, I appreciate it. > If the RocksDB is already open in the cache, you cannot open another handle to it or it will throw an exception. It was the key sentence to understand the problem. Now I got it. If there is another open db instance somewhere in the system (=ContainerCache) we have no possible way to open it again. Now I hate the static property of ContainerCache even better. And I have no better idea for here. Just hope that we will have time to fix ContainerCache in general ;-) I have some bad feeling that this code also changes the code path of the container import during closed container replication. But I tried to think hard and couldn't find any edge cases where it can really fail. So let me repeat my +1 and merge it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
