elek commented on pull request #1549:
URL: https://github.com/apache/ozone/pull/1549#issuecomment-727968190
Thanks the update @sodonnel. I am not sure if I fully understand the new
patch, but you will see from my comments:
1. I agree: static is evil. Especially together with MiniOzoneCluster
2. I have some strange feeling about the exception throwing part in
`KeyValueContainerUtil.parseKVContainerData`. It doesn't look very nice and
would like to understand if it's really neded.
`KeyValueContainerUtil.parseKVContainerData` are called only from two
places: 1. the initial import after boot, 2. the import after closed
replication.
Can we use uncached db in both cases? In that case It would be possible to
always created uncached data.
If not, we can add `DatanodeStore` as a parameter of
`KeyValueContainerUtil.parseKVContainerData` and you can always decide which
store is used (cached / uncached)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
