ayushtkn commented on a change in pull request #1619:
URL: https://github.com/apache/ozone/pull/1619#discussion_r529620252
##########
File path:
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java
##########
@@ -723,6 +726,12 @@ public boolean mkdirs(Path f, FsPermission permission)
throws IOException {
return mkdir(f);
}
+ @Override
+ public long getDefaultBlockSize() {
+ return (long) getConf().getStorageSize(
+ OZONE_SCM_BLOCK_SIZE, OZONE_SCM_BLOCK_SIZE_DEFAULT, StorageUnit.BYTES);
Review comment:
Is this block size used by client while writing? In create and
createNonRecursive it tends to ignore the specified block size.
So, if it isn't correct, Isn't it same as not implementing it? `FileSystem`
will anyway return some value, that can be tweaked as well by
`fs.local.block.size`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
