adoroszlai commented on a change in pull request #1619:
URL: https://github.com/apache/ozone/pull/1619#discussion_r529758307
##########
File path:
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java
##########
@@ -723,6 +726,12 @@ public boolean mkdirs(Path f, FsPermission permission)
throws IOException {
return mkdir(f);
}
+ @Override
+ public long getDefaultBlockSize() {
+ return (long) getConf().getStorageSize(
+ OZONE_SCM_BLOCK_SIZE, OZONE_SCM_BLOCK_SIZE_DEFAULT, StorageUnit.BYTES);
Review comment:
> In create and createNonRecursive it tends to ignore the specified
block size.
Ozone also ignores it and uses uniform block size on server side
(configurable via this `OZONE_SCM_BLOCK_SIZE` property).
> can be tweaked as well by `fs.local.block.size`
You are right, we could achieve the same result by forcing this config to
the same value as SCM block size. I think it's simpler and cleaner to override
the method than to keep the config in sync.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
