adoroszlai commented on a change in pull request #1619:
URL: https://github.com/apache/ozone/pull/1619#discussion_r530134818
##########
File path:
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
##########
@@ -698,6 +701,12 @@ public boolean mkdirs(Path f, FsPermission permission)
throws IOException {
return mkdir(f);
}
+ @Override
+ public long getDefaultBlockSize() {
+ return (long) getConf().getStorageSize(
+ OZONE_SCM_BLOCK_SIZE, OZONE_SCM_BLOCK_SIZE_DEFAULT, StorageUnit.BYTES);
Review comment:
This is intended to be used by the client that creates the file. Once
the file is closed, the actual block size can be queried via
`getBlockSize(Path)`. Currently `getDefaultBlockSize()` returns 32MB,
regardless of SCM config:
https://github.com/apache/hadoop/blob/a6df05bf5e24d04852a35b096c44e79f843f4776/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java#L2521-L2522
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]