adoroszlai opened a new pull request #1667:
URL: https://github.com/apache/ozone/pull/1667
## What changes were proposed in this pull request?
1. Replace shell functions and variables that were originally copied from
Hadoop.
* Deprecate `HADOOP_*` variables, but use their values, unless the
corresponding `OZONE_` variable is also defined (which indicates "new code").
* `HADOOP_CONF_DIR` is replaced by `OZONE_CONFIG_DIR` (instead of
`OZONE_CONF_DIR`) to workaround a behavior `envtoconf` that cannot handle
variables named `*_CONF_*`.
2. Drop unmaintained Windows scripts
3. Drop empty `mapreduce`, `yarn` etc. directories in final artifact, they
are no longer necessary.
4. Fix wrong accumulation of return codes in `start-ozone.sh`: it was
incremented for the first and third commands and unconditionally set for the
second one, so the result of the first command was lost. It should be set for
the first one instead.
https://issues.apache.org/jira/browse/HDDS-4525
## How was this patch tested?
Added Bats test (for deprecation) and acceptance tests (for `ozone
classpath` and `ozone envvars` commands).
Changed MR acceptance tests to globally define both `HADOOP_CLASSPATH` and
`OZONE_CLASSPATH`. This confirms that shaded Ozone FS jar being present in
`HADOOP_CLASSPATH` does not break Ozone startup. Previously `HADOOP_CLASSPATH`
had to be limited to the Hadoop containers.
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/405676505
Manually tested `start-ozone.sh` and `stop-ozone.sh` in `ozonescripts`
environment (see HDDS-4556 for automating the smoketest).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
