fapifta commented on a change in pull request #1667:
URL: https://github.com/apache/ozone/pull/1667#discussion_r543029654
##########
File path: hadoop-ozone/dist/src/shell/ozone/start-ozone.sh
##########
@@ -64,68 +63,53 @@ if [[ $# -ge 1 ]]; then
dataStartOpt="$startOpt"
;;
*)
- hadoop_exit_with_usage 1
+ ozone_exit_with_usage 1
;;
esac
fi
#Add other possible options
nameStartOpt="$nameStartOpt $*"
-SECURITY_ENABLED=$("${HADOOP_HDFS_HOME}/bin/ozone" getconf -confKey
hadoop.security.authentication | tr '[:upper:]' '[:lower:]' 2>&-)
-SECURITY_AUTHORIZATION_ENABLED=$("${HADOOP_HDFS_HOME}/bin/ozone" getconf
-confKey hadoop.security.authorization | tr '[:upper:]' '[:lower:]' 2>&-)
-
-#if [[ ${SECURITY_ENABLED} == "kerberos" || ${SECURITY_AUTHORIZATION_ENABLED}
-# == "true" ]]; then
-# echo "Ozone is not supported in a security enabled cluster."
-# exit 1
-#fi
-
-#SECURITY_ENABLED=$("${HADOOP_HDFS_HOME}/bin/ozone" getozoneconf -confKey
hadoop.security.authentication | tr '[:upper:]' '[:lower:]' 2>&-)
-#SECURITY_AUTHORIZATION_ENABLED=$("${HADOOP_HDFS_HOME}/bin/ozone" getozoneconf
-confKey hadoop.security.authorization | tr '[:upper:]' '[:lower:]' 2>&-)
-#if [[ ${SECURITY_ENABLED} == "kerberos" || ${SECURITY_AUTHORIZATION_ENABLED}
== "true" ]]; then
-# echo "Ozone is not supported in a security enabled cluster."
-# exit 1
-#fi
+SECURITY_ENABLED=$("${OZONE_HOME}/bin/ozone" getconf -confKey
hadoop.security.authentication | tr '[:upper:]' '[:lower:]' 2>&-)
+SECURITY_AUTHORIZATION_ENABLED=$("${OZONE_HOME}/bin/ozone" getconf -confKey
hadoop.security.authorization | tr '[:upper:]' '[:lower:]' 2>&-)
# datanodes (using default workers file)
echo "Starting datanodes"
-hadoop_uservar_su hdfs datanode "${HADOOP_HDFS_HOME}/bin/ozone" \
+ozone_uservar_su hdfs datanode "${OZONE_HOME}/bin/ozone" \
--workers \
- --config "${HADOOP_CONF_DIR}" \
+ --config "${OZONE_CONFIG_DIR}" \
--daemon start \
datanode ${dataStartOpt}
-(( HADOOP_JUMBO_RETCOUNTER=HADOOP_JUMBO_RETCOUNTER + $? ))
+OZONE_JUMBO_RETCOUNTER=$?
Review comment:
Is this changed intentionally from accumulation to a set? Probably, but
I wanted to be sure, and even so if this is the first place where we can safely
set if this runs in just a pure context, this variable may have an initial
value in some workflow which makes it worth to preserve the external value even
at the first assignment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
