GlenGeng commented on a change in pull request #1852:
URL: https://github.com/apache/ozone/pull/1852#discussion_r569234397
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImplV2.java
##########
@@ -279,9 +279,10 @@ public int getNumOfValidTransactions() throws IOException {
/**
* Called in SCMStateMachine#notifyLeaderChanged when current SCM becomes
- * leader.
+ * leader.
*/
- public void clearTransactionToDNsCommitMap() {
+ public void clear() {
Review comment:
Please rename to `onBecomeLeader()`
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogStateManager.java
##########
@@ -42,4 +42,6 @@ void increaseRetryCountOfTransactionInDB(ArrayList<Long>
txIDs)
KeyValue<Long, DeletedBlocksTransaction>> getReadOnlyIterator();
void onFlush();
+
+ void clear();
Review comment:
ditto. `onBecomeLeader()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
