GlenGeng commented on pull request #1852: URL: https://github.com/apache/ozone/pull/1852#issuecomment-772511619
Hey Rui, after a second thought, I realized that my suggestion (the second commit) is wrong, sorry for that. Your first commit is deterministic for `increaseRetryCountOfTransactionInDB `. Given accross different SCMs, - the rocksDB is the same at the same raft log index, - and they has the same raft log, which means they will apply the same `increaseRetryCountOfTransactionInDB The generated `transactionRetryCountMap` is deterministic, under all kinds of failovers, including restart, become leader and step down. The real problem here is, this solution does not decrease the number of fsync. In non-HA mode, each write to DB will call fsync, and in HA mode, the writes will be buffered, but each write will trigger a raft client request, which will call fsync on raft log. Let's go througth this problem again. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
