amaliujia commented on pull request #1852: URL: https://github.com/apache/ozone/pull/1852#issuecomment-772997638
@GlenGeng unfortunately with transaction buffer that we cannot flush retry count into DB immediately thus we probably have to accept the non-deterministic result for this moment. First of all, the current implementation is already bad because it reads from DB and then try to write into DB, thus in the worst case, DB value never increase thus for a txID it retries forever. So we have to introduce the in-memory state in state manager. Then, I think the non-deterministic here might not be a big deal. Even though DB state could be different, but 1. The count in DB will not be overwrite back because we have in-memory state now. (or it becomes consistent through installSnapshot) 2. there is a maxRetry as a bound. At least current PR will avoid the worst case. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
