ChenSammi commented on code in PR #7455:
URL: https://github.com/apache/ozone/pull/7455#discussion_r1865256454
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -667,17 +642,6 @@ public void createBucket(
.setKeyName(bucketArgs.getEncryptionKey()).build();
}
- List<OzoneAcl> listOfAcls = getAclList();
- //ACLs from BucketArgs
- if (bucketArgs.getAcls() != null) {
- listOfAcls.addAll(bucketArgs.getAcls());
- }
- // Link bucket default acl
- if (bucketArgs.getSourceVolume() != null
- && bucketArgs.getSourceBucket() != null) {
- listOfAcls.add(linkBucketDefaultAcl());
Review Comment:
Good point.
if (bucketArgs.getAcls() != null) {
listOfAcls.addAll(bucketArgs.getAcls());
}
is still there, moved to line 685. while linkBucketDefaultAcl() is removed.
Since we have ACL de-duplication on server side, let me add this
linkBucketDefaultAcl back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
