ChenSammi commented on code in PR #7455:
URL: https://github.com/apache/ozone/pull/7455#discussion_r1867239780
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java:
##########
@@ -322,16 +324,25 @@ private boolean isECBucket(BucketInfo bucketInfo) {
* @param omVolumeArgs
*/
private void addDefaultAcls(OmBucketInfo omBucketInfo,
- OmVolumeArgs omVolumeArgs) {
- // Add default acls for bucket creator.
+ OmVolumeArgs omVolumeArgs, OzoneManager ozoneManager) throws OMException
{
List<OzoneAcl> acls = new ArrayList<>();
+ // Add default acls
+ acls.addAll(getDefaultAclList(createUGIForApi(),
ozoneManager.getConfiguration()));
if (omBucketInfo.getAcls() != null) {
+ // Add acls for bucket creator.
acls.addAll(omBucketInfo.getAcls());
}
+ // Link bucket default acl
+ if (omBucketInfo.getSourceBucket() != null &&
omBucketInfo.getSourceVolume() != null) {
+ acls.add(LINK_BUCKET_DEFAULT_ACL);
Review Comment:
make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
