ChenSammi commented on PR #7455: URL: https://github.com/apache/ozone/pull/7455#issuecomment-2499510152
1. move adding default ACL from client to server side 2. refactor code, move static function OMDirectoryCreateRequest#getAllParentInfo and OMDirectoryCreateRequest#createDirectoryKeyInfoWithACL to OMKeyRequest. These static functions in OMDirectoryCreateRequest are referenced in other OMClientRequests which makes the code looks strange, and the limitation of static function cannot call non-static function makes code hard to maintain and add new logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
