hemantk-12 commented on code in PR #7567:
URL: https://github.com/apache/ozone/pull/7567#discussion_r1881239933
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/test/java/org/apache/ozone/rocksdiff/TestRocksDBCheckpointDiffer.java:
##########
@@ -1794,7 +1794,7 @@ public void testShouldSkipNode(Map<String, String>
columnFamilyToPrefixMap,
.getCompactionNodeMap().values().stream()
.sorted(Comparator.comparing(CompactionNode::getFileName))
.map(node ->
- rocksDBCheckpointDiffer.shouldSkipNode(node,
+ RocksDiffUtils.shouldSkipNode(node,
Review Comment:
Tests (`testShouldSkipNode` and `testShouldSkipNodeEdgeCase`) should be
moved to `TestRocksDiffUtils`. If not part of this PR, create a follow-up task.
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDiffUtils.java:
##########
@@ -113,4 +115,35 @@ public static boolean doesSstFileContainKeyRange(String
filepath,
}
+ @VisibleForTesting
Review Comment:
Remove this visibility tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
