swamirishi commented on code in PR #7567: URL: https://github.com/apache/ozone/pull/7567#discussion_r1883954882
########## hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDiffUtils.java: ########## @@ -113,4 +115,35 @@ public static boolean doesSstFileContainKeyRange(String filepath, } + @VisibleForTesting Review Comment: it is visible for testing since this shouldSkipNode function is being used only by tests and a function inside RocksDiffUtils. We could have made it private if not for the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
