swamirishi commented on PR #7567: URL: https://github.com/apache/ozone/pull/7567#issuecomment-2541486185
> > ## How was this patch tested? > > Unit tests > > Sorry, I don't think that's correct. The only changed test is for calling `shouldSkipNode` from its new home, `RocksDiffUtils`. The behavior change in `RocksDBCheckpointDiffer` did not require changing any tests, so this case does not seem to be covered by tests. > > Maybe "tested manually" would be more appropriate. I have added unit test for this case as part of this PR https://github.com/apache/ozone/pull/7563/commits/8548a539bd85c77c58a9ef0f5da55ce1f43e6309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
