ivandika3 commented on code in PR #7700:
URL: https://github.com/apache/ozone/pull/7700#discussion_r1919452843
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -899,11 +898,13 @@ public String getMultipartKeyFSO(String volume, String
bucket, String key, Strin
final long volumeId = getVolumeId(volume);
final long bucketId = getBucketId(volume,
bucket);
- long parentId =
- OMFileRequest.getParentID(volumeId, bucketId, key, this);
-
- String fileName = OzoneFSUtils.getFileName(key);
+ final String nonFSOMultipartKey =
+ getMultipartKey(volume, bucket, key, uploadId);
Review Comment:
Let's rename `nonFSOMultipartKey` to `multipartKey`. `nonFSOMultipartKey`
name is quite confusing since we are dealing with FSO MPU key.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -899,11 +898,13 @@ public String getMultipartKeyFSO(String volume, String
bucket, String key, Strin
final long volumeId = getVolumeId(volume);
final long bucketId = getBucketId(volume,
bucket);
- long parentId =
- OMFileRequest.getParentID(volumeId, bucketId, key, this);
-
- String fileName = OzoneFSUtils.getFileName(key);
+ final String nonFSOMultipartKey =
+ getMultipartKey(volume, bucket, key, uploadId);
+ final OmMultipartKeyInfo multipartKeyInfo =
+ getMultipartInfoTable().get(nonFSOMultipartKey);
Review Comment:
Please handle null `OmMultipartKeyInfo` if the entry does not exist in
`multipartInfoTable` to prevent NPE that might crash OM since
`RuntimeException` is not caught in `validateAndUpdateCache`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
