ivandika3 commented on code in PR #7700:
URL: https://github.com/apache/ozone/pull/7700#discussion_r1921704107
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -899,11 +898,13 @@ public String getMultipartKeyFSO(String volume, String
bucket, String key, Strin
final long volumeId = getVolumeId(volume);
final long bucketId = getBucketId(volume,
bucket);
- long parentId =
- OMFileRequest.getParentID(volumeId, bucketId, key, this);
-
- String fileName = OzoneFSUtils.getFileName(key);
+ final String nonFSOMultipartKey =
+ getMultipartKey(volume, bucket, key, uploadId);
Review Comment:
Let's make the following convention:
- `multipartKey` is the key in `multipartInfoTable` (regardless whether the
underlying bucket is FSO or OBS) that's created in `initiateMultiaprtUpload`
- `multipartOpenKey` is the key in `openKeyTable` / `openFileTable` that's
created in `initiateMultipartUpload`
- `multipartOpenPartKey` is the key in `openKeyTable` / `openFileTable`
that's created in `OMKeyCreateRequest` when uploading a part key.
You can refer to https://issues.apache.org/jira/browse/HDDS-9098. So I
suggest to rename it to `multipartKey`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
