sokui commented on code in PR #7700:
URL: https://github.com/apache/ozone/pull/7700#discussion_r1920594888
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -899,11 +898,13 @@ public String getMultipartKeyFSO(String volume, String
bucket, String key, Strin
final long volumeId = getVolumeId(volume);
final long bucketId = getBucketId(volume,
bucket);
- long parentId =
- OMFileRequest.getParentID(volumeId, bucketId, key, this);
-
- String fileName = OzoneFSUtils.getFileName(key);
+ final String nonFSOMultipartKey =
+ getMultipartKey(volume, bucket, key, uploadId);
Review Comment:
TBH, I think `multipartKey` is ambitious. A `multipartKey` could be a FSO
multipartKey or nonFSO multipartKey, since here we are dealing with FSO, that's
why I intentionally name it as `nonFSOMultipartKey` so that the reader can
understand we should not directly return this value.
If you think `multipartKey` is conventionally mean nonFSO multipartKey, I
can rename it. Pls let me know. Thanks
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -899,11 +898,13 @@ public String getMultipartKeyFSO(String volume, String
bucket, String key, Strin
final long volumeId = getVolumeId(volume);
final long bucketId = getBucketId(volume,
bucket);
- long parentId =
- OMFileRequest.getParentID(volumeId, bucketId, key, this);
-
- String fileName = OzoneFSUtils.getFileName(key);
+ final String nonFSOMultipartKey =
+ getMultipartKey(volume, bucket, key, uploadId);
+ final OmMultipartKeyInfo multipartKeyInfo =
+ getMultipartInfoTable().get(nonFSOMultipartKey);
Review Comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
