errose28 commented on code in PR #7682:
URL: https://github.com/apache/ozone/pull/7682#discussion_r1922870865


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/FSORepairTool.java:
##########
@@ -359,15 +343,10 @@ private void 
handleUnreachableAndUnreferencedObjects(OmVolumeArgs volume, OmBuck
 
           if (!isReachable(dirKey)) {
             if (!isDirectoryInDeletedDirTable(dirKey)) {
-              info("Found unreferenced directory: " + dirKey);
               unreferencedStats.addDir();
 
-              if (!repair) {
-                if (verbose) {
-                  info("Marking unreferenced directory " + dirKey + " for 
deletion.");
-                }
-              } else {
-                info("Deleting unreferenced directory " + dirKey);
+              info("Deleting unreferenced directory " + dirKey);

Review Comment:
   I think we should still only print individual file and dir information if 
the verbose flag is given. If an orphan tree issue occurs we could be looking 
at millions of entries here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to