adoroszlai commented on PR #7682: URL: https://github.com/apache/ozone/pull/7682#issuecomment-2606526241
> Can we add tests for repair commands that they in fact do not make changes accidentally - Tests for `FSORepairTool` already cover both modes. - I can update tests for `QuotaTrigger` and `TransactionInfoRepair`. The latter is also being changed in #7689, and I want to avoid conflicts. - `RecoverSCMCertificate` and `SnapshotChainRepair` have no tests at all. Created HDDS-12121 and HDDS-12122 for addressing that. I think it's out of scope in this PR to add tests from scratch, since we need to repro the broken state that's being repaired. We can put this PR on hold until #7689 is merged, and HDDS-12121 and HDDS-12122 are implemented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
