SaketaChalamchala commented on code in PR #7867:
URL: https://github.com/apache/ozone/pull/7867#discussion_r1955417423


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ratis/ServerNotLeaderException.java:
##########
@@ -35,15 +35,15 @@ public class ServerNotLeaderException extends IOException {
       Pattern.compile(".*Suggested leader is Server:([^:]*)(:[0-9]+).*",
           Pattern.DOTALL);
 
-  public ServerNotLeaderException(RaftPeerId currentPeerId) {
-    super("Server:" + currentPeerId + " is not the leader. Could not " +
+  public ServerNotLeaderException(RaftPeerId currentPeerId, String hostname) {
+    super("Server:" + currentPeerId + "(" + hostname + ") is not the leader. 
Could not " +

Review Comment:
   Thanks for the patch @chiacyu. Could you also log the roleType (Ex. SCM) to 
the log message like so, `roleType + " Server:"` as mentioned in the JIRA?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to