SaketaChalamchala commented on code in PR #7867:
URL: https://github.com/apache/ozone/pull/7867#discussion_r1960819023
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/protocol/SCMSecurityProtocolServerSideTranslatorPB.java:
##########
@@ -82,7 +82,7 @@ public SCMSecurityResponse submitRequest(RpcController
controller,
if (!scm.checkLeader()) {
RatisUtil.checkRatisException(
scm.getScmHAManager().getRatisServer().triggerNotLeaderException(),
- scm.getSecurityProtocolRpcPort(), scm.getScmId());
+ scm.getSecurityProtocolRpcPort(), scm.getScmId(), scm.getHostname(),
"SCM");
Review Comment:
nit: You could make role type `SCM` a static final field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]