SaketaChalamchala commented on code in PR #7867:
URL: https://github.com/apache/ozone/pull/7867#discussion_r1960817749


##########
hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/ratis/TestServerNotLeaderExceptionMessageParsing.java:
##########
@@ -30,13 +30,13 @@ public void testServerNotLeaderException() {
 
     // Test hostname with "."
     final String msg =
-        "Server:cf0bc565-a41b-4784-a24d-3048d5a5b013 is not the leader. "
+        "SCM Server:cf0bc565-a41b-4784-a24d-3048d5a5b013 (172.16.102.111) is 
not the leader. "

Review Comment:
   @chiacyu This exception should match the actual ServerNotLeaderException 
message. Based on your patch to the `ServerNotLeaderException.java` there 
shouldn't be a space between the RaftPeerID and hostname, right?
   The message will be `SCM 
Server:cf0bc565-a41b-4784-a24d-3048d5a5b013(172.16.102.111) is not the leader.`
   
   Could you correct this in all the messages?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to