ivandika3 commented on code in PR #7817:
URL: https://github.com/apache/ozone/pull/7817#discussion_r1957251456
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java:
##########
@@ -328,7 +330,10 @@ public Response put(@PathParam("bucket") String bucketName,
public Response listMultipartUploads(
@PathParam("bucket") String bucketName,
- @QueryParam("prefix") String prefix)
+ @QueryParam("prefix") String prefix,
+ @QueryParam("key-marker") String keyMarker,
+ @QueryParam("upload-id-marker") String uploadIdMarker,
+ @QueryParam("max-uploads") @DefaultValue("1000") @Min(1) @Max(1000) int
maxUploads)
Review Comment:
I think all these `@QueryParam` annotations should be put in the
`BucketEndpoint#get` instead. Should only work for annotated methods (`@GET`,
`@POST`, `@PUT`, `@DELETED`, etc).
Please help to remove the `@PathParam("bucket")` and `@QueryParam("prefix")
since they should not have any effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
