ivandika3 commented on code in PR #7817:
URL: https://github.com/apache/ozone/pull/7817#discussion_r1957672527
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java:
##########
@@ -820,19 +821,19 @@ public boolean isSstFilteringSvcEnabled() {
@Override
public OmMultipartUploadList listMultipartUploads(String volumeName,
- String bucketName, String prefix) throws OMException {
+ String bucketName, String prefix, String keyMarker, String
uploadIdMarker, int maxUploads) throws OMException {
Preconditions.checkNotNull(volumeName);
Preconditions.checkNotNull(bucketName);
metadataManager.getLock().acquireReadLock(BUCKET_LOCK, volumeName,
bucketName);
try {
- Set<String> multipartUploadKeys =
+ MultipartUploadKeys multipartUploadKeys =
Review Comment:
You meant moving this to `OmMetadataManagerImpl`?
I agree that we should only do one iteration of `multipartInfoTable`, and
since `OmMetadataManagerIMpl#getMultipartUploadKeys` are only used in
`KeyManagerImpl#listMultipartUploads`, it is fine to change it to suit your
needs. For example we can change `OmMetadataManagerIMpl#getMultipartUploadKeys`
to `OmMetadataManagerIMpl#listMultipartUploads` that returns
`List<OmMultipartKeyInfo>` (`OmMetadataManagerImpl` only takes care of simple
OM DB operations), and the `KeyManagerImpl#listMultipartUploads` will be in
charge of setting the `nextKeyMarker`, `nextUploadId`, and `isTruncated`,
finally converting it to `OmMultipartUploadList`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
