prashantpogde commented on a change in pull request #1998:
URL: https://github.com/apache/ozone/pull/1998#discussion_r607425053
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/BasicUpgradeFinalizer.java
##########
@@ -57,18 +57,39 @@
protected V versionManager;
protected String clientID;
protected T component;
+ protected UpgradeFinalizationExecutor finalizationExecutor;
private Queue<String> msgs = new ConcurrentLinkedQueue<>();
protected boolean isDone = false;
public BasicUpgradeFinalizer(V versionManager) {
this.versionManager = versionManager;
+ this.finalizationExecutor =
+ new UpgradeFinalizationExecutor();
+ }
+
+ @Override
+ public void setFinalizationExecutor(UpgradeFinalizationExecutor executor) {
+ finalizationExecutor = executor;
+ }
+
+ @Override
+ public UpgradeFinalizationExecutor getFinalizationExecutor() {
+ return finalizationExecutor;
}
public boolean isFinalizationDone() {
return isDone;
}
+ public void markFinalizationDone() {
+ isDone = true;
Review comment:
Currently OMUpgrade is the path that makes use of it and for some OM
upgrade unit tests. If we refactor OM upgrade, we can get rid of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
