prashantpogde commented on a change in pull request #1998:
URL: https://github.com/apache/ozone/pull/1998#discussion_r607425386
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/BasicUpgradeFinalizer.java
##########
@@ -436,4 +456,15 @@ private void logAndThrow(Exception e, String msg,
ResultCodes resultCode)
protected void updateLayoutVersionInDB(V vm, T comp) throws IOException {
throw new UnsupportedOperationException();
}
+
+ protected void postFinalizeUpgrade() throws IOException {
+ }
+
+ protected void finalizeVersionManager(Storage storageConfig)
+ throws UpgradeException {
+ }
+
+ protected boolean preFinalizeUpgrade() throws IOException {
Review comment:
I thought of moving it there and left it as it is to let the Specific
DNFinalizer or SCMFinalizer decide as to what to do with pre/post/finalization
functions.
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/BasicUpgradeFinalizer.java
##########
@@ -436,4 +456,15 @@ private void logAndThrow(Exception e, String msg,
ResultCodes resultCode)
protected void updateLayoutVersionInDB(V vm, T comp) throws IOException {
throw new UnsupportedOperationException();
}
+
+ protected void postFinalizeUpgrade() throws IOException {
+ }
+
+ protected void finalizeVersionManager(Storage storageConfig)
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
