prashantpogde commented on pull request #1998: URL: https://github.com/apache/ozone/pull/1998#issuecomment-816994839
> > These fault injection tests are adding significant time to complete CI runs > > We can skip it in regular integration tests by adding an `<exclude>` for `TestHDDSUpgrade` in `pom.xml`: > > https://github.com/apache/ozone/blob/2ce05944a502c17b38760807c3bddb5398bf7882/pom.xml#L2175-L2191 > > If the pre-existing test case(s) or any other future test cases need to be run as regular integration tests, then the new injection test cases should be separated into a separate class. > > > is there any way to 1) run the conditionally on layout version upgrade > > We can introduce a new workflow for failure injection tests. It can be scheduled with lower frequency. > > Is "layout version upgrade" indicated by changes to specific source files, which we could use as trigger? Also, are you sure that upgrade functionality is not affected by other cocde changes? > > > 1. speed up the tests by running as separate processes? > > We can override surefire fork parameters for this separate workflow. For now we have disabled long running tests. Therefore we do not need to make change in pom.xml for now. But we do need a way to run these test with less frequency e.g. every 50th commit or something like that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
