adoroszlai commented on PR #7922: URL: https://github.com/apache/ozone/pull/7922#issuecomment-2679267905
> > I wonder if any of the config keys should be added to ozone-default.xml, instead of marking as "not in XML" in TestOzoneConfigurationFields. > > Can you remind me what the significance of putting configs in `ozone-default.xml` vs defining the default values in the code is? Adding config keys to `ozone-default.xml` makes them visible for users of Ozone, provides description and tags. Adding them as exception in `TestOzoneConfigurationFields` means they are undocumented. `TestOzoneConfigurationFields` verifies that all keys are present in both XML and constants. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
