adoroszlai commented on code in PR #7922:
URL: https://github.com/apache/ozone/pull/7922#discussion_r1973712264


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java:
##########
@@ -629,6 +629,10 @@ public final class ScmConfigKeys {
       "ozone.scm.ha.dbtransactionbuffer.flush.interval";
   public static final long
       OZONE_SCM_HA_DBTRANSACTIONBUFFER_FLUSH_INTERVAL_DEFAULT = 600 * 1000L;
+
+  public static final String NET_TOPOLOGY_NODE_SWITCH_MAPPING_IMPL_KEY =
+          "net.topology.node.switch.mapping.impl";

Review Comment:
   ```suggestion
         "net.topology.node.switch.mapping.impl";
   ```



##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsConfigKeys.java:
##########
@@ -405,4 +405,32 @@ private HddsConfigKeys() {
 
   public static final String 
OZONE_DATANODE_IO_METRICS_PERCENTILES_INTERVALS_SECONDS_KEY =
       "ozone.volume.io.percentiles.intervals.seconds";
+
+  public static final String HDDS_DATANODE_DNS_INTERFACE_KEY =
+          "hdds.datanode.dns.interface";
+  public static final String HDDS_DATANODE_DNS_NAMESERVER_KEY =
+          "hdds.datanode.dns.nameserver";
+  public static final String HDDS_DATANODE_HOST_NAME_KEY =
+          "hdds.datanode.hostname";
+  public static final String HDDS_DATANODE_DATA_DIR_KEY =
+          "hdds.datanode.data.dir";
+  public static final String HDDS_DATANODE_USE_DN_HOSTNAME =
+          "hdds.datanode.use.datanode.hostname";
+  public static final boolean HDDS_DATANODE_USE_DN_HOSTNAME_DEFAULT = false;
+
+  public static final String HDDS_XFRAME_OPTION_ENABLED = 
"hdds.xframe.enabled";
+  public static final boolean HDDS_XFRAME_OPTION_ENABLED_DEFAULT = true;
+  public static final String HDDS_XFRAME_OPTION_VALUE = "hdds.xframe.value";
+  public static final String HDDS_XFRAME_OPTION_VALUE_DEFAULT = "SAMEORIGIN";
+
+  public static final String HDDS_METRICS_SESSION_ID_KEY =
+          "hdds.metrics.session-id";
+
+  public static final String HDDS_DATANODE_KERBEROS_PRINCIPAL_KEY =
+          "hdds.datanode.kerberos.principal";
+  public static final String HDDS_DATANODE_KERBEROS_KEYTAB_FILE_KEY =
+          "hdds.datanode.kerberos.keytab.file";
+  public static final String HDDS_METRICS_PERCENTILES_INTERVALS_KEY =
+          "hdds.metrics.percentiles.intervals";

Review Comment:
   ```suggestion
     public static final String HDDS_DATANODE_DNS_INTERFACE_KEY =
         "hdds.datanode.dns.interface";
     public static final String HDDS_DATANODE_DNS_NAMESERVER_KEY =
         "hdds.datanode.dns.nameserver";
     public static final String HDDS_DATANODE_HOST_NAME_KEY =
         "hdds.datanode.hostname";
     public static final String HDDS_DATANODE_DATA_DIR_KEY =
         "hdds.datanode.data.dir";
     public static final String HDDS_DATANODE_USE_DN_HOSTNAME =
         "hdds.datanode.use.datanode.hostname";
     public static final boolean HDDS_DATANODE_USE_DN_HOSTNAME_DEFAULT = false;
   
     public static final String HDDS_XFRAME_OPTION_ENABLED = 
"hdds.xframe.enabled";
     public static final boolean HDDS_XFRAME_OPTION_ENABLED_DEFAULT = true;
     public static final String HDDS_XFRAME_OPTION_VALUE = "hdds.xframe.value";
     public static final String HDDS_XFRAME_OPTION_VALUE_DEFAULT = "SAMEORIGIN";
   
     public static final String HDDS_METRICS_SESSION_ID_KEY =
         "hdds.metrics.session-id";
   
     public static final String HDDS_DATANODE_KERBEROS_PRINCIPAL_KEY =
         "hdds.datanode.kerberos.principal";
     public static final String HDDS_DATANODE_KERBEROS_KEYTAB_FILE_KEY =
         "hdds.datanode.kerberos.keytab.file";
     public static final String HDDS_METRICS_PERCENTILES_INTERVALS_KEY =
         "hdds.metrics.percentiles.intervals";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to