adoroszlai commented on PR #7922: URL: https://github.com/apache/ozone/pull/7922#issuecomment-2687052656
On second thought, to avoid feature scope of this task, I think we should: - Keep the exclusion in `TestOzoneConfigurationFields` as done in the PR, because adding to `ozone-default.xml` requires documenting them, which is a different type of task. - Move constants to `HddsConfigKeys` (`NET_TOPOLOGY_NODE_SWITCH_MAPPING_IMPL_KEY` to `ScmConfigKeys`), because `DatanodeConfiguration` is a different kind of object, not just a collection of constants for keys and default values. Adding `@Config` items also requires description, similar to `ozone-default.xml`. - Document in follow-up task, adding to `ozone-default.xml` or `DatanodeConfiguration`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
