errose28 commented on code in PR #7942:
URL: https://github.com/apache/ozone/pull/7942#discussion_r1968543366
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/persistence/ContainerHistory.java:
##########
@@ -100,4 +103,12 @@ public String getState() {
public void setState(String state) {
this.state = state;
}
+
+ public long getDataChecksum() {
+ return dataChecksum;
+ }
+
+ public void setDataChecksum(long dataChecksum) {
+ this.dataChecksum = dataChecksum;
+ }
Review Comment:
We store the checksums on a per-replica basis, but there is no stored
checksum for the container overall in SCM since it doesn't actually know which
one is correct. If I'm understanding this correctly this means we only need
data checksum in `ContainerReplicaHistory` and not `ContainerHistory`. In this
class it looks like the setter is unused and the getter is only used in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
