dombizita commented on code in PR #7942:
URL: https://github.com/apache/ozone/pull/7942#discussion_r1971833101
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java:
##########
@@ -650,6 +665,17 @@ private static boolean keepMisReplicatedRecord(
return false;
}
+ private static boolean keepReplicaMismatchRecord(
+ ContainerHealthStatus container, UnhealthyContainersRecord rec) {
+ if (container.isDataChecksumMismatched()) {
+ updateExpectedReplicaCount(rec, container.expectedPlacementCount());
+ updateActualReplicaCount(rec, container.actualPlacementCount());
+ updateReplicaDelta(rec, container.replicaDelta());
Review Comment:
Can you elaborate on this more? I mean I get that if there is a data
checksum mismatched container expected and actual replica count is not
"important" for us, but they could change and we want to update them, if the
container is still in the REPLICA_MISMATCH state.
This question gave me the idea that with introducing this new state, there
could be containers that are e.g. both over replicated and replica mismatched.
Let me talk about this in a separate comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
