dombizita commented on code in PR #7942:
URL: https://github.com/apache/ozone/pull/7942#discussion_r1981638116
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/persistence/ContainerHistory.java:
##########
@@ -100,4 +103,12 @@ public String getState() {
public void setState(String state) {
this.state = state;
}
+
+ public long getDataChecksum() {
+ return dataChecksum;
+ }
+
+ public void setDataChecksum(long dataChecksum) {
+ this.dataChecksum = dataChecksum;
+ }
Review Comment:
So both classes were added in #1670. `ContainerHistory` is in the
persistence module and it used in the `ContainerEndpoint` class, when returning
replica history related data (in Recon there is a ContainerHistory table:
"_Stores ContainerReplica -> Datanode mapping with last known timestamp. This
is used to determine the last known datanodes when a container is reported
missing_").
`ContainerReplicaHistory` uses the `ContainerReplicaHistoryProto` and it
used at most places in Recon.
I think we should add the `dataChecksum` for both classes, as both track
container replica information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
