elek commented on a change in pull request #2069:
URL: https://github.com/apache/ozone/pull/2069#discussion_r608441478
##########
File path:
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerDataYaml.java
##########
@@ -179,44 +180,7 @@ public void testIncorrectContainerFile() throws
IOException{
GenericTestUtils.assertExceptionContains("No enum constant", ex);
}
}
-
-
Review comment:
Very good question, I planned to discuss it.
```
- // This test is for if we upgrade, and then .container files added by
new
- // server will have new fields added to .container file, after a while
we
- // decided to rollback. Then older ozone can read .container files
- // created or not.
```
This is a limitation of the current checksum calculation. With this
restriction we can never add new fields to the container file.
I think the proper fix here is removing the test and using the upgrade
framework to avoid some situation. This unit test is perfect for the master,
temporary, but we should have an option to add new fields if new features are
allowed (after finalize).
Today it's not possible as upgrade is not merged, but will be possible with
upgrade framework (or just denying all the new EC requests). Therefore, I think
it's safe to remove the unit test, move forward, and later add specific upgrade
tests for EC.
(cc @avijayanhwx )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
