elek commented on a change in pull request #2069:
URL: https://github.com/apache/ozone/pull/2069#discussion_r612246235
##########
File path:
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerDataYaml.java
##########
@@ -179,44 +180,7 @@ public void testIncorrectContainerFile() throws
IOException{
GenericTestUtils.assertExceptionContains("No enum constant", ex);
}
}
-
-
Review comment:
Yes, this is possible, but we wouldn't like to introduce new checksum
fields when we introduce new fields. It should be done (IMHO) together with
another fix which ensures that the new checksum field is always backward
compatible (for example because all the fields are used to calculate the
checksum).
I totally agree that it should be done, but I think it should be done in a
separated issue / patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
