elek commented on a change in pull request #2069:
URL: https://github.com/apache/ozone/pull/2069#discussion_r617471238
##########
File path:
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerDataYaml.java
##########
@@ -179,44 +180,7 @@ public void testIncorrectContainerFile() throws
IOException{
GenericTestUtils.assertExceptionContains("No enum constant", ex);
}
}
-
-
Review comment:
> Also think about the option ignore the additional field when replIndex
is 0, which is default
We can do it, but it doesn't help the compatibility issue, and it requires a
bigger refactor on the write code. I checked it, and it requires refactoring
`ContainerDataRepresenter` (or the surrounding code) which may require bigger
work.
As we need to take care about the compatibility issue related to EC calls
anyway, I suggest using this patch as is to move forward, and we will take care
about all the compatibility testing after the upgrade framework is merged.
Improving the checksum calculation of container files seems to be a good
idea anyway, I created https://issues.apache.org/jira/browse/HDDS-5129 to track
the issue (and discuss the best approach as there are multiple approach).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
