errose28 commented on code in PR #7981:
URL: https://github.com/apache/ozone/pull/7981#discussion_r1988128044
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/DownloadAndImportReplicator.java:
##########
@@ -70,9 +77,19 @@ public void replicate(ReplicationTask task) {
LOG.info("Starting replication of container {} from {} using {}",
containerID, sourceDatanodes, compression);
+ HddsVolume targetVolume = null;
try {
- HddsVolume targetVolume = containerImporter.chooseNextVolume();
+ targetVolume = containerImporter.chooseNextVolume();
Review Comment:
As discussed earlier with @swamirishi, it would be cleaner for some sort of
(auto?)closable "handle" to get returned that marks the requested space as
allocated, which then gets released when the handle is closed. This would be
generically useful on import, create, volume scan, and our current export flow
which requires dumping SST files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
