sumitagrawl commented on code in PR #7981:
URL: https://github.com/apache/ozone/pull/7981#discussion_r1988564319
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/DownloadAndImportReplicator.java:
##########
@@ -70,9 +77,19 @@ public void replicate(ReplicationTask task) {
LOG.info("Starting replication of container {} from {} using {}",
containerID, sourceDatanodes, compression);
+ HddsVolume targetVolume = null;
try {
- HddsVolume targetVolume = containerImporter.chooseNextVolume();
+ targetVolume = containerImporter.chooseNextVolume();
Review Comment:
@swamirishi @errose28 Above generic handler covering most of the cases may
need proper analysis for code improvement. Bug handling should not include
refactoring / cleanup in scope.
IMO, new JIRA can be raised for this activity where code structure interface
and impact can be defined for same to handle in generic case.
@ashishkumar50 Plz check if any specific is required with limited scope for
the bug, and may have JIRA to handle code optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
