ChenSammi commented on code in PR #7981:
URL: https://github.com/apache/ozone/pull/7981#discussion_r1988705028


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/DownloadAndImportReplicator.java:
##########
@@ -70,9 +77,19 @@ public void replicate(ReplicationTask task) {
 
     LOG.info("Starting replication of container {} from {} using {}",
         containerID, sourceDatanodes, compression);
+    HddsVolume targetVolume = null;
 
     try {
-      HddsVolume targetVolume = containerImporter.chooseNextVolume();
+      targetVolume = containerImporter.chooseNextVolume();

Review Comment:
   Yeah, there is more that we can do to finely control the allocated space on 
Datanode.  I filed 
[HDDS-12547](https://issues.apache.org/jira/browse/HDDS-12547) for one of these 
possible improvements.  
   
   I would say let's merge this one, and continue any further improvements in 
new JIRAs.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to